]> git.ipfire.org Git - thirdparty/Python/cpython.git/commit
[3.12] gh-126565: Skip `zipfile.Path.exists` check in write mode (GH-126576) (#126643)
authorMiss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Sun, 10 Nov 2024 15:14:48 +0000 (16:14 +0100)
committerGitHub <noreply@github.com>
Sun, 10 Nov 2024 15:14:48 +0000 (15:14 +0000)
commit5030e81dedd482fd313884991d8b3447dd153fcb
treea731e86ea626ed25bda316d741ddaa1df4314f65
parent61e6f0992f50a32509e94b050decce70ada8885f
[3.12] gh-126565: Skip `zipfile.Path.exists` check in write mode (GH-126576) (#126643)

gh-126565: Skip `zipfile.Path.exists` check in write mode (GH-126576)

When `zipfile.Path.open` is called, the implementation will check
whether the path already exists in the ZIP file. However, this check is
only required when the ZIP file is in read mode. By swapping arguments
of the `and` operator, the short-circuiting will prevent the check from
being run in write mode.

This change will improve the performance of `open()`, because checking
whether a file exists is slow in write mode, especially when the archive
has many members.
(cherry picked from commit 160758a574d12bf0d965d8206136e7da4f4fd6c3)

Co-authored-by: Jan Hicken <janhicken@users.noreply.github.com>
Lib/zipfile/_path/__init__.py
Misc/NEWS.d/next/Library/2024-11-08-11-06-14.gh-issue-126565.dFFO22.rst [new file with mode: 0644]