]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
serial: 8250: omap: Cleanup on error in request_irq
authorMarkus Schneider-Pargmann <msp@baylibre.com>
Wed, 7 Aug 2024 14:12:25 +0000 (16:12 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 4 Oct 2024 14:29:40 +0000 (16:29 +0200)
commit5060a1be93991a33026c309e5ba5ac0a892deb27
tree5d06889f0c0dac2398575999fbe776945fafc1f7
parentb8e45b910525704010d10c9dcbf2abf3005aa97c
serial: 8250: omap: Cleanup on error in request_irq

[ Upstream commit 35e648a16018b747897be2ccc3ce95ff23237bb5 ]

If devm_request_irq fails, the code does not cleanup many things that
were setup before. Instead of directly returning ret we should jump to
err.

Fixes: fef4f600319e ("serial: 8250: omap: Fix life cycle issues for interrupt handlers")
Signed-off-by: Markus Schneider-Pargmann <msp@baylibre.com>
Reviewed-by: Kevin Hilman <khilman@baylibre.com>
Tested-by: Kevin Hilman <khilman@baylibre.com>
Link: https://lore.kernel.org/r/20240807141227.1093006-4-msp@baylibre.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/tty/serial/8250/8250_omap.c