]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
netfilter: nf_tables: reject mismatching sum of field_len with set key length
authorPablo Neira Ayuso <pablo@netfilter.org>
Tue, 28 Jan 2025 11:26:33 +0000 (12:26 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 13 Mar 2025 11:50:15 +0000 (12:50 +0100)
commit5083a7ae45003456c253e981b30a43f71230b4a3
tree19113db8fd607dfe57dc8e34ca5e0dbf5863faf1
parentd712ca4807cead46f8852ecf786bf4e9f6c4fb76
netfilter: nf_tables: reject mismatching sum of field_len with set key length

commit 1b9335a8000fb70742f7db10af314104b6ace220 upstream.

The field length description provides the length of each separated key
field in the concatenation, each field gets rounded up to 32-bits to
calculate the pipapo rule width from pipapo_init(). The set key length
provides the total size of the key aligned to 32-bits.

Register-based arithmetics still allows for combining mismatching set
key length and field length description, eg. set key length 10 and field
description [ 5, 4 ] leading to pipapo width of 12.

Cc: stable@vger.kernel.org
Fixes: 3ce67e3793f4 ("netfilter: nf_tables: do not allow mismatch field size and set key length")
Reported-by: Noam Rathaus <noamr@ssd-disclosure.com>
Reviewed-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/netfilter/nf_tables_api.c