]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
broadcom: b44: prevent uninitialized value usage
authorAlexey Simakov <bigalex934@gmail.com>
Fri, 5 Dec 2025 15:58:16 +0000 (18:58 +0300)
committerJakub Kicinski <kuba@kernel.org>
Wed, 10 Dec 2025 09:02:20 +0000 (01:02 -0800)
commit50b3db3e11864cb4e18ff099cfb38e11e7f87a68
tree20b22bc3f28d5a75460a6b9178cb863b2ed279c5
parent6af2a01d65f89e73c1cbb9267f8880d83a88cee4
broadcom: b44: prevent uninitialized value usage

On execution path with raised B44_FLAG_EXTERNAL_PHY, b44_readphy()
leaves bmcr value uninitialized and it is used later in the code.

Add check of this flag at the beginning of the b44_nway_reset() and
exit early of the function with restarting autonegotiation if an
external PHY is used.

Fixes: 753f492093da ("[B44]: port to native ssb support")
Reviewed-by: Jonas Gorski <jonas.gorski@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Alexey Simakov <bigalex934@gmail.com>
Reviewed-by: Michael Chan <michael.chan@broadcom.com>
Link: https://patch.msgid.link/20251205155815.4348-1-bigalex934@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/broadcom/b44.c