]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
usb: gadget: core: Check for unset descriptor
authorChris Wulff <crwulff@gmail.com>
Thu, 25 Jul 2024 01:04:20 +0000 (21:04 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 19 Aug 2024 03:45:44 +0000 (05:45 +0200)
commit50c5248b0ea8aae0529fdf28dac42a41312d3b62
tree59ee46ad0f39084ec23ac5dc2886641150f44e5b
parent741403cfbf8b958bde61a5e5858c63cd82423ce9
usb: gadget: core: Check for unset descriptor

commit 973a57891608a98e894db2887f278777f564de18 upstream.

Make sure the descriptor has been set before looking at maxpacket.
This fixes a null pointer panic in this case.

This may happen if the gadget doesn't properly set up the endpoint
for the current speed, or the gadget descriptors are malformed and
the descriptor for the speed/endpoint are not found.

No current gadget driver is known to have this problem, but this
may cause a hard-to-find bug during development of new gadgets.

Fixes: 54f83b8c8ea9 ("USB: gadget: Reject endpoints with 0 maxpacket value")
Cc: stable@vger.kernel.org
Signed-off-by: Chris Wulff <crwulff@gmail.com>
Link: https://lore.kernel.org/r/20240725010419.314430-2-crwulff@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/gadget/udc/core.c