]> git.ipfire.org Git - thirdparty/libcgroup.git/commit
api.c: Fix handling of full cg_mount_table[]
authorTom Hromatka <tom.hromatka@oracle.com>
Thu, 9 Jun 2022 18:45:29 +0000 (12:45 -0600)
committerTom Hromatka <tom.hromatka@oracle.com>
Thu, 9 Jun 2022 18:46:48 +0000 (12:46 -0600)
commit50de38f821f5ea367f9a92a802a45659dc45614d
treed17c5b8fa333abe5dc40f94290d131abc3687543
parentaa6d6301581f86759291b65704e91a31cb100cb4
api.c: Fix handling of full cg_mount_table[]

Commit 9ce90c7edd28 ("api.c: fix segfault in cgroup_populate_mount_points()")
added logic to handle the case when there are 100+ cgroup mounts and
not overflow the cg_mount_table[].  But elsewhere in the libcgroup
code, it's expected that the last entry in the cg_mount_table[] has
a null name entry.

When the cg_mount_table[] is full, make the name of the last entry
null so that loops know to exit.  Also, add a couple bail out points
in cgroup_populate_mount_points() to ensure that we don't write
beyond the end of the table.

Depending upon the order in which the tests are run, this failure can
manifest itself as follows:
$ cat tests/ftests/ftests-nocontainer.sh.log
free(): invalid pointer
./ftests-nocontainer.sh: line 18: 199390 Aborted
(core dumped) ./ftests.py -l 10 -L "$START_DIR/ftests-nocontainer.py.log" --no-container -n Libcg"$RANDOM"
FAIL ftests-nocontainer.sh (exit status: 134)

Fixes: 9ce90c7edd28 ("api.c: fix segfault in cgroup_populate_mount_points()")
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
Reviewed-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>
src/api.c