]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
media: i2c: Add note to prevent buggy code re-use
authorKrzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Tue, 30 Dec 2025 08:34:36 +0000 (09:34 +0100)
committerHans Verkuil <hverkuil+cisco@kernel.org>
Fri, 16 Jan 2026 13:08:52 +0000 (14:08 +0100)
commit5152437f7610eb522fd233ab548a19d4601cbc2a
tree23cc440773006ed1982c4b678ab062d3068f0427
parent2f130245f2143fa8f4da77071f844911d2c69319
media: i2c: Add note to prevent buggy code re-use

adv7604 and et8ek8 sensor drivers have mixed up logical and line level
for reset/powerdown signal.  They call it a reset signal (it indeed
behaves like that), but drivers assert the reset to operate which is
clearly incorrect and relies on wrong ACTIVE_HIGH flag in the DTS.

People in discussions copy existing poor code and claim they can repeat
same mistake, so add a note to prevent that.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
drivers/media/i2c/adv7604.c
drivers/media/i2c/et8ek8/et8ek8_driver.c