]> git.ipfire.org Git - thirdparty/linux.git/commit
can: gs_usb: gs_usb_xmit_callback(): fix handling of failed transmitted URBs
authorMarc Kleine-Budde <mkl@pengutronix.de>
Sat, 8 Nov 2025 09:01:01 +0000 (10:01 +0100)
committerMarc Kleine-Budde <mkl@pengutronix.de>
Sun, 16 Nov 2025 16:03:43 +0000 (17:03 +0100)
commit516a0cd1c03fa266bb67dd87940a209fd4e53ce7
tree653089f88746956a16d2f1c19e2c638cf42d7b39
parent30db4451c7f6aabcada029b15859a76962ec0cf8
can: gs_usb: gs_usb_xmit_callback(): fix handling of failed transmitted URBs

The driver lacks the cleanup of failed transfers of URBs. This reduces the
number of available URBs per error by 1. This leads to reduced performance
and ultimately to a complete stop of the transmission.

If the sending of a bulk URB fails do proper cleanup:
- increase netdev stats
- mark the echo_sbk as free
- free the driver's context and do accounting
- wake the send queue

Closes: https://github.com/candle-usb/candleLight_fw/issues/187
Fixes: d08e973a77d1 ("can: gs_usb: Added support for the GS_USB CAN devices")
Link: https://patch.msgid.link/20251114-gs_usb-fix-usb-callbacks-v1-1-a29b42eacada@pengutronix.de
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
drivers/net/can/usb/gs_usb.c