]> git.ipfire.org Git - thirdparty/haproxy.git/commit
BUG/MINOR: Fix prometheus '# TYPE' and '# HELP' headers
authorAnthonin Bonnefoy <anthonin.bonnefoy@datadoghq.com>
Wed, 7 Aug 2019 15:45:25 +0000 (17:45 +0200)
committerChristopher Faulet <cfaulet@haproxy.com>
Mon, 12 Aug 2019 06:51:28 +0000 (08:51 +0200)
commit51c3aa4628cf597eb133f6ae8bb36e09139a73dc
tree3f36dd7f7828801ec72596cde551f0a28a54d51a
parent579e3e3dd51de734ead47960ce125f6feabc33fa
BUG/MINOR: Fix prometheus '# TYPE' and '# HELP' headers

Prometheus protocol defines HELP and TYPE as a token after the '#' and
the space after the '#' is necessary.
This is expected in the prometheus python client for example
(https://github.com/prometheus/client_python/blob/a8f5c80f651ea570577c364203e0edbef67db727/prometheus_client/parser.py#L194)
and the missing space is breaking the parsing of metrics' type.

This patch must be backported to 2.0.
contrib/prometheus-exporter/service-prometheus.c