]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
ALSA: usb-audio: Evaluate packsize caps at the right place
authorTakashi Iwai <tiwai@suse.de>
Fri, 10 Apr 2026 14:32:19 +0000 (16:32 +0200)
committerTakashi Iwai <tiwai@suse.de>
Fri, 10 Apr 2026 14:34:06 +0000 (16:34 +0200)
commit52521e8398839105ef8eb22b3f0993f9b0d11a57
treef7c2aa9627ba61360eb1d3f6786fcb996d54a95a
parent00afb1811fa638dacf125dd1c343b7a181624dfd
ALSA: usb-audio: Evaluate packsize caps at the right place

We introduced the upper bound checks of the packet sizes by the
ep->maxframesize for avoiding the URB submission errors.  However, the
check was applied at an incorrect place in the function
snd_usb_endpoint_set_params() where ep->maxframesize isn't defined
yet; the value is defined at a bit later position.  So this ended up
with a failure at the first run while the second run works.

For fixing it, move the check at the correct place, right after the
calculation of ep->maxframesize in the same function.

Fixes: 7fe8dec3f628 ("ALSA: usb-audio: Cap the packet size pre-calculations")
Link: https://bugzilla.kernel.org/show_bug.cgi?id=221292
Cc: <stable@vger.kernel.org>
Link: https://patch.msgid.link/20260410143220.1676344-1-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/usb/endpoint.c