]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Fix pg_dumpall to work for databases flagged as read-only.
authorKevin Grittner <kgrittn@postgresql.org>
Sat, 30 Nov 2013 18:07:05 +0000 (12:07 -0600)
committerKevin Grittner <kgrittn@postgresql.org>
Sat, 30 Nov 2013 18:07:05 +0000 (12:07 -0600)
commit52898e005f06b1529299b4b14510de3ab259a2f1
tree1847229ed87cb8d2c0d25b781e1c5c4295e25361
parenta74f50a3f627ac2ef73c77dc1b6ea67d0d44da50
Fix pg_dumpall to work for databases flagged as read-only.

pg_dumpall's charter is to be able to recreate a database cluster's
contents in a virgin installation, but it was failing to honor that
contract if the cluster had any ALTER DATABASE SET
default_transaction_read_only settings.  By including a SET command
for the connection for each connection opened by pg_dumpall output,
errors are avoided and the source cluster is successfully
recreated.

There was discussion of whether to also set this for the connection
applying pg_dump output, but it was felt that it was both less
appropriate in that context, and far easier to work around.

Backpatch to all supported branches.
src/bin/pg_dump/pg_dumpall.c