]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
bus: fsl-mc: fix an error handling in fsl_mc_device_add()
authorHaoxiang Li <lihaoxiang@isrc.iscas.ac.cn>
Sat, 24 Jan 2026 10:20:54 +0000 (18:20 +0800)
committerChristophe Leroy (CS GROUP) <chleroy@kernel.org>
Wed, 28 Jan 2026 12:35:48 +0000 (13:35 +0100)
commit52f527d0916bcdd7621a0c9e7e599b133294d495
tree2a81734dba3522f402e2da8aa1fae72584349382
parent65d5727645acbc019fd17d47f47b743eb116ff14
bus: fsl-mc: fix an error handling in fsl_mc_device_add()

In fsl_mc_device_add(), device_initialize() is called first.
put_device() should be called to drop the reference if error
occurs. And other resources would be released via put_device
-> fsl_mc_device_release. So remove redundant kfree() in
error handling path.

Fixes: bbf9d17d9875 ("staging: fsl-mc: Freescale Management Complex (fsl-mc) bus driver")
Cc: stable@vger.kernel.org
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/all/b767348e-d89c-416e-acea-1ebbff3bea20@stanley.mountain/
Signed-off-by: Su Hui <suhui@nfschina.com>
Suggested-by: Christophe Leroy (CS GROUP) <chleroy@kernel.org>
Signed-off-by: Haoxiang Li <lihaoxiang@isrc.iscas.ac.cn>
Reviewed-by: Ioana Ciornei <ioana.ciornei@nxp.com>
Link: https://lore.kernel.org/r/20260124102054.1613093-1-lihaoxiang@isrc.iscas.ac.cn
Signed-off-by: Christophe Leroy (CS GROUP) <chleroy@kernel.org>
drivers/bus/fsl-mc/fsl-mc-bus.c