]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
tipc: re-order conditions in tipc_crypto_key_rcv()
authorDan Carpenter <dan.carpenter@linaro.org>
Fri, 17 Jan 2025 09:36:14 +0000 (12:36 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 21 Feb 2025 12:49:33 +0000 (13:49 +0100)
commit5328b25bbdfb89128915bb92330bbce16008b817
treeb884f2f454a05720971c5396217c923595edca0f
parent3a78d7c76b04cb9ab7e61f0cabd3e99d8ce03ff9
tipc: re-order conditions in tipc_crypto_key_rcv()

[ Upstream commit 5fe71fda89745fc3cd95f70d06e9162b595c3702 ]

On a 32bit system the "keylen + sizeof(struct tipc_aead_key)" math could
have an integer wrapping issue.  It doesn't matter because the "keylen"
is checked on the next line, but just to make life easier for static
analysis tools, let's re-order these conditions and avoid the integer
overflow.

Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Simon Horman <horms@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
net/tipc/crypto.c