]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
ALSA: sh: Use standard helper for buffer accesses
authorTakashi Iwai <tiwai@suse.de>
Thu, 28 Nov 2024 10:49:38 +0000 (11:49 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 2 Jan 2025 09:34:17 +0000 (10:34 +0100)
commit532a29e8fa28e80e5fdd08a73c307a196542e222
tree1a5c0eca9c13c4ea1039bb420f74bb1cace22f7f
parent4287eb3951ca1f419da16a81de9e9e37fc0fa6b7
ALSA: sh: Use standard helper for buffer accesses

[ Upstream commit 9b5f8ee43e48c25fbe1a10163ec04343d750acd0 ]

The SH DAC audio driver uses the kmalloc'ed buffer as the main PCM
buffer, and the data is transferred via hrtimer callbacks manually
from there to the hardware.  Meanwhile, some of its code are written
as if the buffer is on iomem and use the special helpers for the iomem
(e.g. copy_from_iter_toio() or memset_io()).  Those are rather useless
and the standard helpers should be used.

Similarly, the PCM mmap callback is set to a special one with
snd_pcm_lib_mmap_iomem, but this is also nonsense, because SH
architecture doesn't support this function, hence it leads just to
NULL -- the fallback to the standard helper.

This patch replaces those special setups with the standard ones.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202411281337.I4M07b7i-lkp@intel.com/
Link: https://patch.msgid.link/20241128104939.13755-1-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
sound/sh/sh_dac_audio.c