]> git.ipfire.org Git - thirdparty/libvirt.git/commit
qemu: fix missing error reports in capabilities probing
authorDaniel P. Berrangé <berrange@redhat.com>
Mon, 15 Jun 2020 12:43:26 +0000 (13:43 +0100)
committerDaniel P. Berrangé <berrange@redhat.com>
Wed, 24 Jun 2020 11:28:27 +0000 (12:28 +0100)
commit5331c4804f4f419b9e75741084f926e52413d3a1
treede180ae366dc07d70d17a6aaf8fa7127c7061d73
parentd00227480cda8119e30055e7c1fdc1677b77ad39
qemu: fix missing error reports in capabilities probing

The "virsh domcapabilities --arch ppc64" command will fail with no
error message set if qemu-system-ppc64 is not currently installed.

This is because virQEMUCapsCacheLookup() does not report any error
message if not capabilities can be obtained from the cache. Almost
all methods calling this expected an error to be set on failure.

Once that's fixed though, we see a further bug which is that
virQEMUCapsCacheLookupDefault() is passing a NULL binary path to
virQEMUCapsCacheLookup(), so we need to catch that too.

Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
src/qemu/qemu_capabilities.c
src/qemu/qemu_domain.c