]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
ALSA: core: Serialize deferred fasync state checks
authorCássio Gabriel <cassiogabrielcontato@gmail.com>
Wed, 6 May 2026 03:34:47 +0000 (00:34 -0300)
committerTakashi Iwai <tiwai@suse.de>
Wed, 6 May 2026 08:07:36 +0000 (10:07 +0200)
commit5337213381df578058e2e41da93cbd0e4639935f
tree60dbe636cc177f2cff2faed68d3f631250c36027
parent01801e20d69346e1e6cec0d908f1cea3a49e51b5
ALSA: core: Serialize deferred fasync state checks

snd_fasync_helper() updates fasync->on under snd_fasync_lock, and
snd_fasync_work_fn() now also evaluates fasync->on under the same
lock. snd_kill_fasync() still tests the flag before taking the lock,
leaving an unsynchronized read against FASYNC enable/disable updates.

Move the enabled-state check into the locked section.

Also clear fasync->on under snd_fasync_lock in snd_fasync_free()
before unlinking the pending entry. Together with the locked sender-side
check, this publishes teardown before flushing the deferred work and
prevents a racing sender from requeueing the entry after free has
started.

Fixes: ef34a0ae7a26 ("ALSA: core: Add async signal helpers")
Fixes: 8146cd333d23 ("ALSA: core: Fix potential data race at fasync handling")
Cc: stable@vger.kernel.org
Signed-off-by: Cássio Gabriel <cassiogabrielcontato@gmail.com>
Link: https://patch.msgid.link/20260506-alsa-core-fasync-on-lock-v1-1-ea48c77d6ca4@gmail.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/core/misc.c