]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
scsi: core: Use GFP_NOIO to avoid circular locking dependency
authorRik van Riel <riel@surriel.com>
Tue, 28 Jan 2025 21:35:39 +0000 (16:35 -0500)
committerMartin K. Petersen <martin.petersen@oracle.com>
Mon, 3 Feb 2025 22:08:13 +0000 (17:08 -0500)
commit5363ee9d110e139584c2d92a0b640bc210588506
tree26446387afb5d5e32e743d36b40b2692d1a41230
parent839a74b5649c9f41d939a05059b5ca6b17156d03
scsi: core: Use GFP_NOIO to avoid circular locking dependency

Filesystems can write to disk from page reclaim with __GFP_FS
set. Marc found a case where scsi_realloc_sdev_budget_map() ends up in
page reclaim with GFP_KERNEL, where it could try to take filesystem
locks again, leading to a deadlock.

WARNING: possible circular locking dependency detected
6.13.0 #1 Not tainted
------------------------------------------------------
kswapd0/70 is trying to acquire lock:
ffff8881025d5d78 (&q->q_usage_counter(io)){++++}-{0:0}, at: blk_mq_submit_bio+0x461/0x6e0

but task is already holding lock:
ffffffff81ef5f40 (fs_reclaim){+.+.}-{0:0}, at: balance_pgdat+0x9f/0x760

The full lockdep splat can be found in Marc's report:

https://lkml.org/lkml/2025/1/24/1101

Avoid the potential deadlock by doing the allocation with GFP_NOIO, which
prevents both filesystem and block layer recursion.

Reported-by: Marc Aurèle La France <tsi@tuyoix.net>
Signed-off-by: Rik van Riel <riel@surriel.com>
Link: https://lore.kernel.org/r/20250129104525.0ae8421e@fangorn
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/scsi_scan.c