]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
NFS: Guard against READDIR loop when entry names exceed MAXNAMELEN
authorBenjamin Coddington <bcodding@redhat.com>
Tue, 22 Aug 2023 18:22:38 +0000 (14:22 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 19 Sep 2023 10:22:43 +0000 (12:22 +0200)
commit53a1e5ab1b119d4a6b874765b97a85e4dcd5bf1b
treef7dfc489782a6799305fb918ee4f50200e5b5791
parent19a648a07572c70fbe16faf0fafaf3dce9fd998a
NFS: Guard against READDIR loop when entry names exceed MAXNAMELEN

[ Upstream commit f67b55b6588bcf9316a1e6e8d529100a5aa3ebe6 ]

Commit 64cfca85bacd asserts the only valid return values for
nfs2/3_decode_dirent should not include -ENAMETOOLONG, but for a server
that sends a filename3 which exceeds MAXNAMELEN in a READDIR response the
client's behavior will be to endlessly retry the operation.

We could map -ENAMETOOLONG into -EBADCOOKIE, but that would produce
truncated listings without any error.  The client should return an error
for this case to clearly assert that the server implementation must be
corrected.

Fixes: 64cfca85bacd ("NFS: Return valid errors from nfs2/3_decode_dirent()")
Signed-off-by: Benjamin Coddington <bcodding@redhat.com>
Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
fs/nfs/nfs2xdr.c
fs/nfs/nfs3xdr.c