]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
btrfs: fix memory leak on duplicated memory in the qgroup assign ioctl
authorMiquel Sabaté Solà <mssola@mssola.com>
Thu, 25 Sep 2025 18:41:39 +0000 (20:41 +0200)
committerDavid Sterba <dsterba@suse.com>
Mon, 13 Oct 2025 20:29:27 +0000 (22:29 +0200)
commit53a4acbfc1de85fa637521ffab4f4e2ee03cbeeb
treead6198240ac0a00735a7381a7ec96fdcd3a45409
parent7e5a5983edda664e8e4bb20af17b80f5135c655c
btrfs: fix memory leak on duplicated memory in the qgroup assign ioctl

On 'btrfs_ioctl_qgroup_assign' we first duplicate the argument as
provided by the user, which is kfree'd in the end. But this was not the
case when allocating memory for 'prealloc'. In this case, if it somehow
failed, then the previous code would go directly into calling
'mnt_drop_write_file', without freeing the string duplicated from the
user space.

Fixes: 4addc1ffd67a ("btrfs: qgroup: preallocate memory before adding a relation")
CC: stable@vger.kernel.org # 6.12+
Reviewed-by: Boris Burkov <boris@bur.io>
Reviewed-by: Filipe Manana <fdmanana@suse.com>
Signed-off-by: Miquel Sabaté Solà <mssola@mssola.com>
Signed-off-by: Filipe Manana <fdmanana@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/ioctl.c