]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
rtc: tps6594: Fix integer overflow on 32bit systems
authorDan Carpenter <dan.carpenter@linaro.org>
Wed, 11 Dec 2024 09:32:34 +0000 (12:32 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 8 Feb 2025 09:02:08 +0000 (10:02 +0100)
commit53b0c7b15accb18d15d95c7fe68f61630ebfd1ca
tree8f8af035104bcc26c68c263b47d2ed4059eea926
parent981ad4c882096e7375b8c2181dd4c3ee58ea5bae
rtc: tps6594: Fix integer overflow on 32bit systems

[ Upstream commit 09c4a610153286cef54d4f0c85398f4e32fc227e ]

The problem is this multiply in tps6594_rtc_set_offset()

tmp = offset * TICKS_PER_HOUR;

The "tmp" variable is an s64 but "offset" is a long in the
(-277774)-277774 range.  On 32bit systems a long can hold numbers up to
approximately two billion.  The number of TICKS_PER_HOUR is really large,
(32768 * 3600) or roughly a hundred million.  When you start multiplying
by a hundred million it doesn't take long to overflow the two billion
mark.

Probably the safest way to fix this is to change the type of
TICKS_PER_HOUR to long long because it's such a large number.

Fixes: 9f67c1e63976 ("rtc: tps6594: Add driver for TPS6594 RTC")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/1074175e-5ecb-4e3d-b721-347d794caa90@stanley.mountain
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/rtc/rtc-tps6594.c