]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
arm64/gcs: Fix error handling in arch_set_shadow_stack_status()
authorBreno Leitao <leitao@debian.org>
Mon, 2 Feb 2026 18:32:51 +0000 (10:32 -0800)
committerWill Deacon <will@kernel.org>
Tue, 3 Feb 2026 09:30:20 +0000 (09:30 +0000)
commit53c998527ffa60f9deda8974a11ad39790684159
treec92d0a97035f3b9bba7afe47cd7f959b0d87582b
parentbb0c99e08ab9aa6d04b40cb63c72db9950d51749
arm64/gcs: Fix error handling in arch_set_shadow_stack_status()

alloc_gcs() returns an error-encoded pointer on failure, which comes
from do_mmap(), not NULL.

The current NULL check fails to detect errors, which could lead to using
an invalid GCS address.

Use IS_ERR_VALUE() to properly detect errors, consistent with the
check in gcs_alloc_thread_stack().

Fixes: b57180c75c7e ("arm64/gcs: Implement shadow stack prctl() interface")
Reviewed-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Breno Leitao <leitao@debian.org>
Signed-off-by: Will Deacon <will@kernel.org>
arch/arm64/mm/gcs.c