]> git.ipfire.org Git - thirdparty/apache/httpd.git/commit
mod_proxy_http: don't strip EOS when spooling request body to file.
authorYann Ylavic <ylavic@apache.org>
Fri, 29 May 2020 17:05:29 +0000 (17:05 +0000)
committerYann Ylavic <ylavic@apache.org>
Fri, 29 May 2020 17:05:29 +0000 (17:05 +0000)
commit53e2b681365306df932ec1b4ded187dab8e99c10
tree36d3cd7fe39afaf1818f5927c0a1c87977d3c2ac
parentc0879a7ad9a5e1fb9d8b370a2001c555130dfd72
mod_proxy_http: don't strip EOS when spooling request body to file.

To prevent stream_reqbody() from sending the FILE and EOS bucket in separate
brigades, and thus apr_file_setaside() to trigger if network congestion occurs
with the backend, restore the EOS in spool_reqbody_cl() which was stripped
when spooling the request body to a file.

Until APR r1878279 is released (and installed by users), apr_file_setaside()
on a temporary file (mktemp) will simply drop the file cleanup, leaking the
fd and inode..

This fixes BZ 64452.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1878280 13f79535-47bb-0310-9956-ffa450edef68
CHANGES
modules/proxy/mod_proxy_http.c