]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
ASoC: amd: acp3x-rt5682-max9836: Add missing error check for clock acquisition
authorChen Ni <nichen@iscas.ac.cn>
Tue, 10 Mar 2026 02:42:46 +0000 (10:42 +0800)
committerMark Brown <broonie@kernel.org>
Wed, 11 Mar 2026 13:21:01 +0000 (13:21 +0000)
commit53f3a900e9a383d47af7253076e19f510c5708d0
tree65d58e9a5aba4304cdc0c4773f38b1d27ff35d9d
parent30e4b2290cc2a8d1b9ddb9dcb9c981df1f2a7399
ASoC: amd: acp3x-rt5682-max9836: Add missing error check for clock acquisition

The acp3x_5682_init() function did not check the return value of
clk_get(), which could lead to dereferencing error pointers in
rt5682_clk_enable().

Fix this by:
1. Changing clk_get() to the device-managed devm_clk_get().
2. Adding proper IS_ERR() checks for both clock acquisitions.

Fixes: 6b8e4e7db3cd ("ASoC: amd: Add machine driver for Raven based platform")
Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
Link: https://patch.msgid.link/20260310024246.2153827-1-nichen@iscas.ac.cn
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/amd/acp3x-rt5682-max9836.c