]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
reset: hisilicon: fix potential NULL pointer dereference
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Thu, 26 Jul 2018 00:47:19 +0000 (19:47 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 21 Nov 2018 08:22:04 +0000 (09:22 +0100)
commit543c52975eb8d946678840fdb7a590db3c04a6a5
treefd70bbb5a65a53bb1943e3be1b66e071f6b48b4c
parent84d1d9cc1c0c61a8b8d254c23e31a91fbbb40698
reset: hisilicon: fix potential NULL pointer dereference

commit e9a2310fb689151166df7fd9971093362d34bd79 upstream.

There is a potential execution path in which function
platform_get_resource() returns NULL. If this happens,
we will end up having a NULL pointer dereference.

Fix this by replacing devm_ioremap with devm_ioremap_resource,
which has the NULL check and the memory region request.

This code was detected with the help of Coccinelle.

Cc: stable@vger.kernel.org
Fixes: 97b7129cd2af ("reset: hisilicon: change the definition of hisi_reset_init")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/clk/hisilicon/reset.c