]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
ext4: validate s_reserved_gdt_blocks on mount
authorTheodore Ts'o <tytso@mit.edu>
Wed, 6 Jul 2016 00:01:52 +0000 (20:01 -0400)
committerSasha Levin <alexander.levin@verizon.com>
Mon, 22 Aug 2016 16:23:04 +0000 (12:23 -0400)
commit5467159ce7daea9c2f7548b1a7835ee6cecbfb68
treeb6347a4e8d714a1e96060565333919395f6b4b86
parent926d244dfa891826a40d6af950209c3b90868149
ext4: validate s_reserved_gdt_blocks on mount

[ Upstream commit e1d8c1feecf672379c50ab045fd94548468bc987 ]

[ Upstream commit 5b9554dc5bf008ae7f68a52e3d7e76c0920938a2 ]

If s_reserved_gdt_blocks is extremely large, it's possible for
ext4_init_block_bitmap(), which is called when ext4 sets up an
uninitialized block bitmap, to corrupt random kernel memory.  Add the
same checks which e2fsck has --- it must never be larger than
blocksize / sizeof(__u32) --- and then add a backup check in
ext4_init_block_bitmap() in case the superblock gets modified after
the file system is mounted.

Reported-by: Vegard Nossum <vegard.nossum@oracle.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Cc: stable@vger.kernel.org
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
fs/ext4/balloc.c
fs/ext4/super.c