]> git.ipfire.org Git - thirdparty/libvirt.git/commit
projects / thirdparty / libvirt.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 8b994d5) | patch
util: fix wrong comparison inside virStoragePermsCopy()
authorJulio Faracco <jcfaracco@gmail.com>
Fri, 2 Jun 2017 01:58:06 +0000 (22:58 -0300)
committerPeter Krempa <pkrempa@redhat.com>
Fri, 2 Jun 2017 07:37:44 +0000 (09:37 +0200)
commit54aee01d876ad3d331ead6ea0a574a1326faae32
tree6636f70b426bb5b49de7c040d53762d4d95c4745tree | snapshot
parent8b994d5189b848b00de795a35ce945d6b87d42edcommit | diff
util: fix wrong comparison inside virStoragePermsCopy()

VIR_STRDUP returns -1 if the string copy was not successful. So, the
current comparison/logic is throwing an error when VIR_STRDUP() returns
1. Only when source is NULL, it is considering as a success which is
not right.

Signed-off-by: Julio Faracco <jcfaracco@gmail.com>
src/util/virstoragefile.c diff | blob | blame | history
Mirror of https://github.com/libvirt/libvirt.git