]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
tipc: guard against string buffer overrun
authorSimon Horman <horms@kernel.org>
Thu, 1 Aug 2024 18:35:37 +0000 (19:35 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 17 Oct 2024 13:11:26 +0000 (15:11 +0200)
commit54dae0e9063ed23c9acf8d5ab9b18d3426a8ac18
tree4ab488b06eca42335c28a51c5a98aacefce37a9e
parent1c9b8775062f8d854a80caf186af57fc617d454c
tipc: guard against string buffer overrun

[ Upstream commit 6555a2a9212be6983d2319d65276484f7c5f431a ]

Smatch reports that copying media_name and if_name to name_parts may
overwrite the destination.

 .../bearer.c:166 bearer_name_validate() error: strcpy() 'media_name' too large for 'name_parts->media_name' (32 vs 16)
 .../bearer.c:167 bearer_name_validate() error: strcpy() 'if_name' too large for 'name_parts->if_name' (1010102 vs 16)

This does seem to be the case so guard against this possibility by using
strscpy() and failing if truncation occurs.

Introduced by commit b97bf3fd8f6a ("[TIPC] Initial merge")

Compile tested only.

Reviewed-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20240801-tipic-overrun-v2-1-c5b869d1f074@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
net/tipc/bearer.c