]> git.ipfire.org Git - thirdparty/linux.git/commit
ipv6: prevent infinite loop in rt6_nlmsg_size()
authorEric Dumazet <edumazet@google.com>
Fri, 25 Jul 2025 14:07:23 +0000 (14:07 +0000)
committerJakub Kicinski <kuba@kernel.org>
Sat, 26 Jul 2025 18:31:00 +0000 (11:31 -0700)
commit54e6fe9dd3b0e7c481c2228782c9494d653546da
treedac0641b490a79de3749bee6a941214dab3c3430
parentea2f921db7a483a526058c5b5b8162edd88dabe5
ipv6: prevent infinite loop in rt6_nlmsg_size()

While testing prior patch, I was able to trigger
an infinite loop in rt6_nlmsg_size() in the following place:

list_for_each_entry_rcu(sibling, &f6i->fib6_siblings,
fib6_siblings) {
rt6_nh_nlmsg_size(sibling->fib6_nh, &nexthop_len);
}

This is because fib6_del_route() and fib6_add_rt2node()
uses list_del_rcu(), which can confuse rcu readers,
because they might no longer see the head of the list.

Restart the loop if f6i->fib6_nsiblings is zero.

Fixes: d9ccb18f83ea ("ipv6: Fix soft lockups in fib6_select_path under high next hop churn")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Link: https://patch.msgid.link/20250725140725.3626540-3-edumazet@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/ipv6/ip6_fib.c
net/ipv6/route.c