]> git.ipfire.org Git - thirdparty/linux.git/commit
wifi: ath12k: Remove ath12k_get_num_hw() helper function
authorKarthikeyan Periyasamy <quic_periyasa@quicinc.com>
Sun, 12 Jan 2025 07:16:29 +0000 (12:46 +0530)
committerJeff Johnson <jeff.johnson@oss.qualcomm.com>
Tue, 14 Jan 2025 20:53:01 +0000 (12:53 -0800)
commit54fcdcf07baa9cb34359094f1b829b29d0845cb6
tree82f29dadfc7d28402bcac9a314fd27897221dee3
parent812a30271d48cff5edc39aeb436b3bebd558f5cf
wifi: ath12k: Remove ath12k_get_num_hw() helper function

Currently, the ath12k_get_num_hw() helper function takes the device handle
as an argument. Here, the number of hardware is retrieved from the group
handle. Demanding the device handle from the caller is unnecessary since
in some cases the group handle is already available. Additionally, there
is no longer a need for multiple indirections to get the number of
hardware. Therefore, remove this helper function and directly use
ag->num_hw. This change also fixes the below Smatch static checker
warning.

Smatch warning:
ath12k_mac_destroy() error: we previously assumed 'ab' could be null

Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.3.1-00173-QCAHKSWPL_SILICONZ-1

Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/ath12k/3e705de0-67d1-4437-97ff-4828d83ae2af@stanley.mountain/
Closes: https://scan7.scan.coverity.com/#/project-view/52682/11354?selectedIssue=1602340
Fixes: a343d97f27f5 ("wifi: ath12k: move struct ath12k_hw from per device to group")
Signed-off-by: Karthikeyan Periyasamy <quic_periyasa@quicinc.com>
Acked-by: Kalle Valo <kvalo@kernel.org>
Acked-by: Jeff Johnson <jeff.johnson@oss.qualcomm.com>
Link: https://patch.msgid.link/20250112071630.4059410-4-quic_periyasa@quicinc.com
Signed-off-by: Jeff Johnson <jeff.johnson@oss.qualcomm.com>
drivers/net/wireless/ath/ath12k/core.c
drivers/net/wireless/ath/ath12k/core.h
drivers/net/wireless/ath/ath12k/mac.c