]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
ceph: give up on paths longer than PATH_MAX
authorMax Kellermann <max.kellermann@ionos.com>
Mon, 18 Nov 2024 22:28:28 +0000 (23:28 +0100)
committerIlya Dryomov <idryomov@gmail.com>
Mon, 16 Dec 2024 22:25:43 +0000 (23:25 +0100)
commit550f7ca98ee028a606aa75705a7e77b1bd11720f
tree799a9f9ea0e58110a85832644cf81a6ec023bdba
parentd6fd6f8280f0257ba93f16900a0d3d3912f32c79
ceph: give up on paths longer than PATH_MAX

If the full path to be built by ceph_mdsc_build_path() happens to be
longer than PATH_MAX, then this function will enter an endless (retry)
loop, effectively blocking the whole task.  Most of the machine
becomes unusable, making this a very simple and effective DoS
vulnerability.

I cannot imagine why this retry was ever implemented, but it seems
rather useless and harmful to me.  Let's remove it and fail with
ENAMETOOLONG instead.

Cc: stable@vger.kernel.org
Reported-by: Dario Weißer <dario@cure53.de>
Signed-off-by: Max Kellermann <max.kellermann@ionos.com>
Reviewed-by: Alex Markuze <amarkuze@redhat.com>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
fs/ceph/mds_client.c