]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
iommu/riscv: Fix signedness bug
authorEthan Tidmore <ethantidmore06@gmail.com>
Thu, 19 Mar 2026 18:26:44 +0000 (13:26 -0500)
committerJoerg Roedel <joerg.roedel@amd.com>
Fri, 27 Mar 2026 18:55:52 +0000 (19:55 +0100)
commit553a127cb66523089bc10eb54640205495f4bb5b
treeda04b9e49bbfcf69f0e202a51046ffa7461c46e0
parentb2e5684558edf3e9bbe18d0e0043854994eab1be
iommu/riscv: Fix signedness bug

The function platform_irq_count() returns negative error codes and
iommu->irqs_count is an unsigned integer, so the check
(iommu->irqs_count <= 0) is always impossible.

Make the return value of platform_irq_count() be assigned to ret, check
for error, and then assign iommu->irqs_count to ret.

Detected by Smatch:
drivers/iommu/riscv/iommu-platform.c:119 riscv_iommu_platform_probe() warn:
'iommu->irqs_count' unsigned <= 0

Signed-off-by: Ethan Tidmore <ethantidmore06@gmail.com>
Fixes: 5c0ebbd3c6c6 ("iommu/riscv: Add RISC-V IOMMU platform device driver")
Reviewed-by: Andrew Jones <andrew.jones@oss.qualcomm.com>
Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
drivers/iommu/riscv/iommu-platform.c