]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
xfs: fix integer overflow in busy extent sort comparator
authorYuto Ohnuki <ytohnuki@amazon.com>
Sat, 28 Mar 2026 17:34:10 +0000 (17:34 +0000)
committerCarlos Maiolino <cem@kernel.org>
Tue, 7 Apr 2026 11:08:27 +0000 (13:08 +0200)
commit553a13e2076d64774910d597977a17022625763d
tree8ce16f608579eefbd4d5b9dcbcd8f54e450727bc
parent59e586d7dc7813910abe20a8281bbc3f1360e08e
xfs: fix integer overflow in busy extent sort comparator

xfs_extent_busy_ag_cmp() subtracts two uint32_t values (group
numbers and block numbers) and returns the result as s32. When
the difference exceeds INT_MAX, the result overflows and the sort
order is corrupted.

Use cmp_int() instead, as was done in commit 362c49098086 ("xfs:
fix integer overflow in bmap intent sort comparator").

Fixes: 4a137e09151e ("xfs: keep a reference to the pag for busy extents")
Signed-off-by: Yuto Ohnuki <ytohnuki@amazon.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Carlos Maiolino <cmaiolino@redhat.com>
Signed-off-by: Carlos Maiolino <cem@kernel.org>
fs/xfs/xfs_extent_busy.c