]> git.ipfire.org Git - thirdparty/linux.git/commit
dlm: use SHUT_RDWR for SCTP shutdown
authorAlexander Aring <aahringo@redhat.com>
Tue, 29 Apr 2025 20:29:11 +0000 (16:29 -0400)
committerDavid Teigland <teigland@redhat.com>
Wed, 30 Apr 2025 14:26:34 +0000 (09:26 -0500)
commit55612ddb62fc12437a7ff2f27b51a8981bc187a4
tree3b6c81cb86f7a88b049188dca0f97094307e7073
parent8a856fdede1669cbaeadeea87fc5b2ac071cee1b
dlm: use SHUT_RDWR for SCTP shutdown

Currently SCTP shutdown() call gets stuck because there is no incoming
EOF indicator on its socket. On the peer side the EOF indicator as
recvmsg() returns 0 will be triggered as mechanism to flush the socket
queue on the receive side. In SCTP recvmsg() function sctp_recvmsg() we
can see that only if sk_shutdown has the bit RCV_SHUTDOWN set SCTP will
recvmsg() will return EOF. The RCV_SHUTDOWN bit will only be set when
shutdown with SHUT_RD is called. We use now SHUT_RDWR to also get a EOF
indicator from recvmsg() call on the shutdown() initiator.

SCTP does not support half closed sockets and the semantic of SHUT_WR is
different here, it seems that calling SHUT_WR on sctp sockets keeps the
socket open to have the possibility to do some specific SCTP operations on
it that we don't do here.

There exists still a difference in the limitations of TCP vs SCTP in
case if we are required to have a half closed socket functionality. This
was tried to archieve with DLM protocol changes in the past and
hopefully we really don't require half closed socket functionality.

Signed-off-by: Alexander Aring <aahringo@redhat.com>
Tested-by: Heming zhao <heming.zhao@suse.com>
Reviewed-by: Heming zhao <heming.zhao@suse.com>
Signed-off-by: David Teigland <teigland@redhat.com>
fs/dlm/lowcomms.c