]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
crypto: octeontx - Fix length check to avoid truncation in ucode_load_store
authorThorsten Blum <thorsten.blum@linux.dev>
Wed, 26 Nov 2025 09:46:13 +0000 (10:46 +0100)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 19 Dec 2025 06:47:47 +0000 (14:47 +0800)
commit5565a72b24fa7935a9f30af386e92c8c9dfb23b9
tree8b5c77bdbffbe799bad75106faa50ea0075cf99a
parent352140d396b14d5f4d50b15f3a50020c2c4f337b
crypto: octeontx - Fix length check to avoid truncation in ucode_load_store

OTX_CPT_UCODE_NAME_LENGTH limits the microcode name to 64 bytes. If a
user writes a string of exactly 64 characters, the original code used
'strlen(buf) > 64' to check the length, but then strscpy() copies only
63 characters before adding a NUL terminator, silently truncating the
copied string.

Fix this off-by-one error by using 'count' directly for the length check
to ensure long names are rejected early and copied without truncation.

Cc: stable@vger.kernel.org
Fixes: d9110b0b01ff ("crypto: marvell - add support for OCTEON TX CPT engine")
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/marvell/octeontx/otx_cptpf_ucode.c