]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
misc: ocxl: fix possible name leak in ocxl_file_register_afu()
authorYang Yingliang <yangyingliang@huawei.com>
Fri, 11 Nov 2022 14:59:29 +0000 (22:59 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 31 Dec 2022 12:26:26 +0000 (13:26 +0100)
commit557b7de055d1e230ddb6664c29d26917b8db9143
treead67e4918ab066405148bbe2de4343aa0adfa91f
parent8d8c1d6a430f0aadb80036e2b1bc0a05f9fad247
misc: ocxl: fix possible name leak in ocxl_file_register_afu()

[ Upstream commit a4cb1004aeed2ab893a058fad00a5b41a12c4691 ]

If device_register() returns error in ocxl_file_register_afu(),
the name allocated by dev_set_name() need be freed. As comment
of device_register() says, it should use put_device() to give
up the reference in the error path. So fix this by calling
put_device(), then the name can be freed in kobject_cleanup(),
and info is freed in info_release().

Fixes: 75ca758adbaf ("ocxl: Create a clear delineation between ocxl backend & frontend")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Acked-by: Andrew Donnellan <ajd@linux.ibm.com>
Acked-by: Frederic Barrat <fbarrat@linux.ibm.com>
Link: https://lore.kernel.org/r/20221111145929.2429271-1-yangyingliang@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/misc/ocxl/file.c