]> git.ipfire.org Git - thirdparty/openvpn.git/commit
phase2_tcp_server: fix Coverity issue 'Dereference after null check'
authorFrank Lichtenheld <frank@lichtenheld.com>
Mon, 25 Mar 2024 07:14:48 +0000 (08:14 +0100)
committerGert Doering <gert@greenie.muc.de>
Mon, 25 Mar 2024 17:00:21 +0000 (18:00 +0100)
commit5591af17694d98054da2cdf4cfd42508a8a4fb8e
treeab1a2ef5d537ee2fac018c49d3067b398c431497
parent11ca69cfac1c6d3ed34652650688a4b3c99573b0
phase2_tcp_server: fix Coverity issue 'Dereference after null check'

As Coverity says:
Either the check against null is unnecessary, or there may be a null
pointer dereference.
In phase2_tcp_server: Pointer is checked against null but then
dereferenced anyway

There is only one caller (link_socket_init_phase2) and it already has
an ASSERT(sig_info). So use that here was well.

v2:
 - fix cleanly by actually asserting that sig_info is defined

Change-Id: I8ef199463d46303129a3f563fd9eace780a58b8a
Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
Acked-by: Arne Schwabe <arne-openvpn@rfc2549.org>
Message-Id: <20240325071448.12143-1-gert@greenie.muc.de>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg28452.html
Signed-off-by: Gert Doering <gert@greenie.muc.de>
(cherry picked from commit e8c629fe64c67ea0a8454753be99db44df7ce53e)
src/openvpn/socket.c