]> git.ipfire.org Git - thirdparty/haproxy.git/commit
BUG/MINOR: tcp-rules: tcp-response must check the buffer's fullness
authorWilly Tarreau <w@1wt.eu>
Mon, 15 Jun 2020 16:08:07 +0000 (18:08 +0200)
committerWilly Tarreau <w@1wt.eu>
Mon, 15 Jun 2020 16:16:20 +0000 (18:16 +0200)
commit55ae1ab9e46bb8c10931cadfe685319e4fa9170c
tree2918f7634d9376c7cacb89c67144f19fe99d19bd
parent9dc92b2650a83a17db9779eadf63cb011be4f8ff
BUG/MINOR: tcp-rules: tcp-response must check the buffer's fullness

It's unclear why the buffer length wasn't considered when tcp-response
rules were added in 1.5-dev3 with commit 97679e790 ("[MEDIUM] Implement
tcp inspect response rules"). But it's impossible to write working
tcp-response content rules as they're always waiting for the expiration
and do not consider the fact that the buffer is full. It's likely that
tcp-response content rules were only used with HTTP traffic.

This may be backported to stable versions, though it's not very
important considering that that nobody reported this in 10 years.
src/tcp_rules.c