]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
mac80211: send ADDBA requests using the tid/queue of the aggregation session
authorFelix Fietkau <nbd@nbd.name>
Thu, 2 Dec 2021 12:45:33 +0000 (13:45 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 22 Dec 2021 08:19:00 +0000 (09:19 +0100)
commit55f8c6f0b2d09b6eec2b2cb5a5ecdf6cef7969f9
tree8740ac31ffa2f72564ce4e7574cbba6fd502eecc
parent4abf352f359961677d8b45bcb92e08c34a25dd3f
mac80211: send ADDBA requests using the tid/queue of the aggregation session

commit 1fe98f5690c4219d419ea9cc190f94b3401cf324 upstream.

Sending them out on a different queue can cause a race condition where a
number of packets in the queue may be discarded by the receiver, because
the ADDBA request is sent too early.
This affects any driver with software A-MPDU setup which does not allocate
packet seqno in hardware on tx, regardless of whether iTXQ is used or not.
The only driver I've seen that explicitly deals with this issue internally
is mwl8k.

Cc: stable@vger.kernel.org
Signed-off-by: Felix Fietkau <nbd@nbd.name>
Link: https://lore.kernel.org/r/20211202124533.80388-1-nbd@nbd.name
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/mac80211/agg-tx.c