]> git.ipfire.org Git - thirdparty/linux.git/commit
drm/nouveau/dispnv50: Don't call drm_atomic_get_crtc_state() in prepare_fb
authorLyude Paul <lyude@redhat.com>
Thu, 11 Dec 2025 19:02:54 +0000 (14:02 -0500)
committerLyude Paul <lyude@redhat.com>
Sat, 20 Dec 2025 05:29:52 +0000 (00:29 -0500)
commit560271e10b2c86e95ea35afa9e79822e4847f07a
tree9696a931462ba8924e9f2c84e3940387cf413454
parent6b991ad8dc3abfe5720fc2e9ee96be63ae43e362
drm/nouveau/dispnv50: Don't call drm_atomic_get_crtc_state() in prepare_fb

Since we recently started warning about uses of this function after the
atomic check phase completes, we've started getting warnings about this in
nouveau. It appears a misplaced drm_atomic_get_crtc_state() call has been
hiding in our .prepare_fb callback for a while.

So, fix this by adding a new nv50_head_atom_get_new() function and use that
in our .prepare_fb callback instead.

Signed-off-by: Lyude Paul <lyude@redhat.com>
Reviewed-by: Dave Airlie <airlied@redhat.com>
Fixes: 1590700d94ac ("drm/nouveau/kms/nv50-: split each resource type into their own source files")
Cc: <stable@vger.kernel.org> # v4.18+
Link: https://patch.msgid.link/20251211190256.396742-1-lyude@redhat.com
drivers/gpu/drm/nouveau/dispnv50/atom.h
drivers/gpu/drm/nouveau/dispnv50/wndw.c