]> git.ipfire.org Git - thirdparty/qemu.git/commit
file-posix: allow BLKZEROOUT with -t writeback
authorStefan Hajnoczi <stefanha@redhat.com>
Thu, 17 Apr 2025 21:10:53 +0000 (17:10 -0400)
committerKevin Wolf <kwolf@redhat.com>
Thu, 22 May 2025 14:54:10 +0000 (16:54 +0200)
commit5634622bcb339f213469eceeff005640492fc902
tree7c98c57894653428c5fc72b649f41e64738f8331
parentff2ab634e4bb3bddcf5f5ee29e0b46f71e3f4b54
file-posix: allow BLKZEROOUT with -t writeback

The Linux BLKZEROOUT ioctl is only invoked when BDRV_O_NOCACHE is set
because old kernels did not invalidate the page cache. In that case
mixing BLKZEROOUT with buffered I/O could lead to corruption.

However, Linux 4.9 commit 22dd6d356628 ("block: invalidate the page
cache when issuing BLKZEROOUT") made BLKZEROOUT coherent with the page
cache.

I have checked that Linux 4.9+ kernels are shipped at least as far back
as Debian 10 (buster), openSUSE Leap 15.2, and RHEL/CentOS 8.

Use BLKZEROOUT with buffered I/O, mostly so `qemu-img ... -t
writeback` can offload write zeroes.

Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-ID: <20250417211053.98700-1-stefanha@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
block/file-posix.c