]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
gtp: disable BH before calling udp_tunnel_xmit_skb()
authorDavid Carlier <devnexen@gmail.com>
Fri, 17 Apr 2026 05:54:08 +0000 (06:54 +0100)
committerJakub Kicinski <kuba@kernel.org>
Mon, 20 Apr 2026 18:46:24 +0000 (11:46 -0700)
commit5638504a2aa9e1b9d72af9060df1a160cce2d379
tree80ec967efed64d8809b696a4753383fae3d82ebf
parentf6315295899415f1ddcf39f7c9cb46d25e2c6c6a
gtp: disable BH before calling udp_tunnel_xmit_skb()

gtp_genl_send_echo_req() runs as a generic netlink doit handler in
process context with BH not disabled. It calls udp_tunnel_xmit_skb(),
which eventually invokes iptunnel_xmit() — that uses __this_cpu_inc/dec
on softnet_data.xmit.recursion to track the tunnel xmit recursion level.

Without local_bh_disable(), the task may migrate between
dev_xmit_recursion_inc() and dev_xmit_recursion_dec(), breaking the
per-CPU counter pairing. The result is stale or negative recursion
levels that can later produce false-positive
SKB_DROP_REASON_RECURSION_LIMIT drops on either CPU.

The other udp_tunnel_xmit_skb() call sites in gtp.c are unaffected:
the data path runs under ndo_start_xmit and the echo response handlers
run from the UDP encap rx softirq, both with BH already disabled.

Fix it by disabling BH around the udp_tunnel_xmit_skb() call, mirroring
commit 2cd7e6971fc2 ("sctp: disable BH before calling
udp_tunnel_xmit_skb()").

Fixes: 6f1a9140ecda ("net: add xmit recursion limit to tunnel xmit functions")
Cc: stable@vger.kernel.org
Signed-off-by: David Carlier <devnexen@gmail.com>
Link: https://patch.msgid.link/20260417055408.4667-1-devnexen@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/gtp.c