]> git.ipfire.org Git - thirdparty/haproxy.git/commit
BUG/MINOR: hlua: fix uninitialized var in hlua_core_get_var()
authorAurelien DARRAGON <adarragon@haproxy.com>
Wed, 24 Jan 2024 15:10:55 +0000 (16:10 +0100)
committerAurelien DARRAGON <adarragon@haproxy.com>
Wed, 24 Jan 2024 15:27:38 +0000 (16:27 +0100)
commit564addcb727bfb3dd46507ec824f11c20c6bb861
tree341735c2fde6ace8626e5d42ec9e321401740bf8
parentab75d89e074cd35133cf2921895074bfd3b92105
BUG/MINOR: hlua: fix uninitialized var in hlua_core_get_var()

As raised by Coverity in GH #2223, f034139bc0 ("MINOR: lua: Allow reading
"proc." scoped vars from LUA core.") causes uninitialized reads due to
smp being passed to vars_get_by_name() without being initialized first.

Indeed, vars_get_by_name() tries to read smp->sess and smp->strm pointers.
As we're only interested in the PROC var scope, it is safe to call
vars_get_by_name() with sess and strm pointers set to NULL, thus we
simply memset smp prior to calling vars_get_by_name() to fix the issue.

This should be backported in 2.9 with f034139bc0.
src/hlua.c