]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
bus: ti-sysc: Flush posted write only after srst_udelay
authorTony Lindgren <tony@atomide.com>
Fri, 24 Nov 2023 08:50:56 +0000 (10:50 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 5 Jan 2024 14:12:28 +0000 (15:12 +0100)
commit565fadc3ea91923e9699aeb3d631f0dbaef3b88d
tree37869541599e60a3e38c32957cd346fbbd1153ff
parente50cfb5447428650104b4c5f3e47608870c59901
bus: ti-sysc: Flush posted write only after srst_udelay

commit f71f6ff8c1f682a1cae4e8d7bdeed9d7f76b8f75 upstream.

Commit 34539b442b3b ("bus: ti-sysc: Flush posted write on enable before
reset") caused a regression reproducable on omap4 duovero where the ISS
target module can produce interconnect errors on boot. Turns out the
registers are not accessible until after a delay for devices needing
a ti,sysc-delay-us value.

Let's fix this by flushing the posted write only after the reset delay.
We do flushing also for ti,sysc-delay-us using devices as that should
trigger an interconnect error if the delay is not properly configured.

Let's also add some comments while at it.

Fixes: 34539b442b3b ("bus: ti-sysc: Flush posted write on enable before reset")
Cc: stable@vger.kernel.org
Signed-off-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/bus/ti-sysc.c