]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
cifs: Fix memory and information leak in smb3_reconfigure()
authorZilin Guan <zilin@seu.edu.cn>
Wed, 24 Dec 2025 15:21:42 +0000 (15:21 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 8 Jan 2026 09:14:13 +0000 (10:14 +0100)
commit5679cc90bb5415801fa29041da0319d9e15d295d
treecb2f296588d6b3c28412086d09f224eb8cfe1a00
parent4f23082b371a8ea87f4da398d0657221541a9836
cifs: Fix memory and information leak in smb3_reconfigure()

[ Upstream commit cb6d5aa9c0f10074f1ad056c3e2278ad2cc7ec8d ]

In smb3_reconfigure(), if smb3_sync_session_ctx_passwords() fails, the
function returns immediately without freeing and erasing the newly
allocated new_password and new_password2. This causes both a memory leak
and a potential information leak.

Fix this by calling kfree_sensitive() on both password buffers before
returning in this error case.

Fixes: 0f0e357902957 ("cifs: during remount, make sure passwords are in sync")
Signed-off-by: Zilin Guan <zilin@seu.edu.cn>
Reviewed-by: ChenXiaoSong <chenxiaosong@kylinos.cn>
Signed-off-by: Steve French <stfrench@microsoft.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
fs/smb/client/fs_context.c