]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
geneve: Remove synchronize_net() in geneve_unquiesce().
authorKuniyuki Iwashima <kuniyu@google.com>
Mon, 18 May 2026 05:07:10 +0000 (05:07 +0000)
committerJakub Kicinski <kuba@kernel.org>
Thu, 21 May 2026 02:12:29 +0000 (19:12 -0700)
commit567dbca22b373b05be0aa46eb2e64ee92d4f4790
tree13b0f992c7af5e3667230e9b13cd05a55b6a8de3
parent2f7f86db167537bc9c6bb848fc77e4f1089aede2
geneve: Remove synchronize_net() in geneve_unquiesce().

When changing the geneve config, geneve_changelink() sandwiches
the config memcpy() between geneve_quiesce() and geneve_unquiesce().

geneve_quiesce() temporarily clears geneve->sock[46] and their
sk_user_data, and then calls synchronize_net() to wait for inflight
fast paths to finish.

geneve_unquiesce() then restores the cleared pointers, but it also
superfluously calls synchronize_net().

The latter synchronize_net() provides no benefit; with or without it,
inflight fast paths can see either the NULL pointers or the original
pointers alongside the new configuration.

Let's remove the redundant synchronize_net() in geneve_unquiesce().

Signed-off-by: Kuniyuki Iwashima <kuniyu@google.com>
Link: https://patch.msgid.link/20260518050726.318824-4-kuniyu@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/geneve.c