]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
scsi: mpt3sas: Fix error return value in _scsih_expander_add()
authorZhen Lei <thunder.leizhen@huawei.com>
Fri, 14 May 2021 08:13:00 +0000 (16:13 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 20 Jul 2021 14:22:36 +0000 (16:22 +0200)
commit5681c9320922859a7b6a54c9d0887efd88f691fe
tree164d93dc9bca506483d82b27ffe3db9b67a0a7d0
parentea2bda11aad9f8f49ea9f90a98bdf689555ef054
scsi: mpt3sas: Fix error return value in _scsih_expander_add()

[ Upstream commit d6c2ce435ffe23ef7f395ae76ec747414589db46 ]

When an expander does not contain any 'phys', an appropriate error code -1
should be returned, as done elsewhere in this function. However, we
currently do not explicitly assign this error code to 'rc'. As a result, 0
was incorrectly returned.

Link: https://lore.kernel.org/r/20210514081300.6650-1-thunder.leizhen@huawei.com
Fixes: f92363d12359 ("[SCSI] mpt3sas: add new driver supporting 12GB SAS")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/scsi/mpt3sas/mpt3sas_scsih.c