]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
pinctrl: renesas: checker: Limit cfg reg enum checks to provided IDs
authorGeert Uytterhoeven <geert+renesas@glider.be>
Mon, 22 Jan 2024 13:43:38 +0000 (14:43 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 13 Apr 2024 11:07:34 +0000 (13:07 +0200)
commit56f5e36dace67d10808774c1d7e9dbcc1b36d573
tree399c3f1b9c334d9c291889b7bd680ef9ce749ca0
parent852ad6a4f55c1e90123eff6d957119d4d5f27726
pinctrl: renesas: checker: Limit cfg reg enum checks to provided IDs

[ Upstream commit 3803584a4e9b65bb5b013f862f55c5055aa86c25 ]

If the number of provided enum IDs in a variable width config register
description does not match the expected number, the checker uses the
expected number for validating the individual enum IDs.

However, this may cause out-of-bounds accesses on the array holding the
enum IDs, leading to bogus enum_id conflict warnings.  Worse, if the bug
is an incorrect bit field description (e.g. accidentally using "12"
instead of "-12" for a reserved field), thousands of warnings may be
printed, overflowing the kernel log buffer.

Fix this by limiting the enum ID check to the number of provided enum
IDs.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Link: https://lore.kernel.org/r/c7385f44f2faebb8856bcbb4e908d846fc1531fb.1705930809.git.geert+renesas@glider.be
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/pinctrl/renesas/core.c