]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
HID: intel-ish-hid: fix NULL-ptr-deref in ishtp_bus_remove_all_clients
authorRyan Lin <ryan.lin@intel.com>
Fri, 30 Jan 2026 05:34:56 +0000 (13:34 +0800)
committerJiri Kosina <jkosina@suse.com>
Mon, 2 Feb 2026 13:37:57 +0000 (14:37 +0100)
commit56f7db581ee73af53cd512e00a6261a025bf1d58
tree5329b25c9f1a088632c9a0c58c886c8dda432b5a
parentaf4fe07a9d963a72438ade96cf090e84b3399d0c
HID: intel-ish-hid: fix NULL-ptr-deref in ishtp_bus_remove_all_clients

During a warm reset flow, the cl->device pointer may be NULL if the
reset occurs while clients are still being enumerated. Accessing
cl->device->reference_count without a NULL check leads to a kernel panic.

This issue was identified during multi-unit warm reboot stress clycles.
Add a defensive NULL check for cl->device to ensure stability under
such intensive testing conditions.

KASAN: null-ptr-deref in range [0000000000000000-0000000000000007]
Workqueue: ish_fw_update_wq fw_reset_work_fn

Call Trace:
 ishtp_bus_remove_all_clients+0xbe/0x130 [intel_ishtp]
 ishtp_reset_handler+0x85/0x1a0 [intel_ishtp]
 fw_reset_work_fn+0x8a/0xc0 [intel_ish_ipc]

Fixes: 3703f53b99e4a ("HID: intel_ish-hid: ISH Transport layer")
Signed-off-by: Ryan Lin <ryan.lin@intel.com>
Signed-off-by: Jiri Kosina <jkosina@suse.com>
drivers/hid/intel-ish-hid/ishtp/bus.c