]> git.ipfire.org Git - thirdparty/asterisk.git/commit
AST-2017-012: Place single RTCP report block at beginning of report.
authorJoshua Colp <jcolp@digium.com>
Thu, 30 Nov 2017 16:12:55 +0000 (16:12 +0000)
committerJoshua Colp <jcolp@digium.com>
Wed, 13 Dec 2017 13:11:48 +0000 (13:11 +0000)
commit5705e8ae0e05602d5399faa561c3119cfb83eca3
treebdfc8f7c0eeab86997959dd2e6aac62d984c8b26
parent2b8a152c6943e75308aa2cd6e3e5245644dbebed
AST-2017-012: Place single RTCP report block at beginning of report.

When the RTCP code was transitioned over to Stasis a code change
was made to keep track of how many reports are present. This count
controlled where report blocks were placed in the RTCP report.

If a compound RTCP packet was received this logic would incorrectly
place a report block in the wrong location resulting in a write
to an invalid location.

This change removes this counting logic and always places the report
block at the first position. If in the future multiple reports are
supported the logic can be extended but for now keeping a count
serves no purpose.

ASTERISK-27382
ASTERISK-27429

Change-Id: Iad6c8a9985c4b608ef493e19c421211615485116
res/res_rtp_asterisk.c