]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
random: pull add_hwgenerator_randomness() declaration into random.h
authorJason A. Donenfeld <Jason@zx2c4.com>
Sun, 13 Feb 2022 15:17:01 +0000 (16:17 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 25 Jun 2022 09:46:35 +0000 (11:46 +0200)
commit57a23e728b087d04ac4991b80941dfc20da5cf5a
treea86110fca7dc69aca57b26cbe7c58b0e66b4246d
parent5357d828bc6abb235121c022fdf3f21e2fb3f12e
random: pull add_hwgenerator_randomness() declaration into random.h

commit b777c38239fec5a528e59f55b379e31b1a187524 upstream.

add_hwgenerator_randomness() is a function implemented and documented
inside of random.c. It is the way that hardware RNGs push data into it.
Therefore, it should be declared in random.h. Otherwise sparse complains
with:

random.c:1137:6: warning: symbol 'add_hwgenerator_randomness' was not declared. Should it be static?

The alternative would be to include hw_random.h into random.c, but that
wouldn't really be good for anything except slowing down compile time.

Cc: Matt Mackall <mpm@selenic.com>
Cc: Theodore Ts'o <tytso@mit.edu>
Acked-by: Herbert Xu <herbert@gondor.apana.org.au>
Reviewed-by: Eric Biggers <ebiggers@google.com>
Reviewed-by: Dominik Brodowski <linux@dominikbrodowski.net>
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/char/hw_random/core.c
include/linux/hw_random.h
include/linux/random.h